WG Demos - Update editorType/widget import statements for editor-related widget demos#33853
Open
charlescordialDevExpress wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WG demo sources to ensure DevExtreme editor-related toolbar items that render dxButton via widget="dxButton" have the required modular widget registration import.
Changes:
- Added side-effect imports for
devextreme/ui/buttonin Vue/React popup and HtmlEditor toolbar customization demos sodxButtonis registered when referenced viawidget="dxButton". - Updated the Angular HtmlEditor toolbar customization demo with a side-effect import (but currently for the wrong widget module).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/Popup/Overview/Vue/App.vue | Adds devextreme/ui/button import to support DxToolbarItem widget="dxButton". |
| apps/demos/Demos/Popup/Overview/ReactJs/App.js | Adds devextreme/ui/button import to support ToolbarItem widget="dxButton". |
| apps/demos/Demos/Popup/Overview/React/App.tsx | Adds devextreme/ui/button import to support ToolbarItem widget="dxButton" (typed options). |
| apps/demos/Demos/HtmlEditor/ToolbarCustomization/Vue/App.vue | Adds devextreme/ui/button import to support toolbar item widget="dxButton". |
| apps/demos/Demos/HtmlEditor/ToolbarCustomization/ReactJs/App.js | Adds devextreme/ui/button import to support toolbar item widget="dxButton". |
| apps/demos/Demos/HtmlEditor/ToolbarCustomization/React/App.tsx | Adds devextreme/ui/button import to support toolbar item widget="dxButton". |
| apps/demos/Demos/HtmlEditor/ToolbarCustomization/Angular/app/app.component.ts | Adds a side-effect import, but it currently imports button_group while the demo uses dxButton. |
Comment on lines
4
to
+5
| import { DxButtonTypes } from 'devextreme-angular/ui/button'; | ||
| import 'devextreme/ui/button_group'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR change?
How did you achieve this?
How can we verify these changes?