Add config option to opt-out of generated query serializer#3749
Add config option to opt-out of generated query serializer#3749cappuc wants to merge 8161 commits into
Conversation
|
|
|
Reviewed PR #3749. The core Task list (5/5 completed)
|
|
@cappuc is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
|
|
TL;DR — Adds a Key changes
Summary | 87 files | 5 commits | base:
When
|
There was a problem hiding this comment.
Important
The core feature (guarding query serializer generation behind plugin.config.querySerializer) is correct and well-tested. However, the diff includes a large unrelated reordering of properties in types.ts that makes the PR harder to review and introduces ordering issues. Please revert the property shuffling and keep only the querySerializer additions.
Task list (5/5 completed)
- Read the diff to identify major areas of change
- Read non-snapshot source changes in detail
- Investigate correctness, config type, and code generation logic
- Verify test coverage and snapshot correctness
- Submit review
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3749 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 595 595
Lines 21365 21366 +1
Branches 6291 6292 +1
=======================================
+ Hits 8284 8285 +1
Misses 10659 10659
Partials 2422 2422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@hey-api/codegen-core
@hey-api/json-schema-ref-parser
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/shared
@hey-api/spec-types
@hey-api/types
@hey-api/vite-plugin
commit: |
perf(hey-api#3819/hey-api#3030): 30x speed up
…rrors-zod-schemas fix(zod): fall back to `z.union()` when discriminated union members are `ZodIntersection`
…tion has no required params
Move options to the last parameter position in both setQueryData and useSetQueryData so it can be properly optional when the operation has no required params. The previous approach placed options? in the middle with a required param after it, which is invalid TypeScript. Also removes duplicate isRequiredOptions declarations introduced in a prior commit.
fix(client-core): resolve runtimeConfigPath relative to generated output
perf(shared/codegen-core): few small performance improvements
…coding fix: incorrect $ref generation for schema names containing / or ~
…minated-union-empty-object fix(zod): fall back to `z.union` for discriminated unions with empty-object members
…t/tanstack-get-query-data
…ery-data feat(@tanstack/query): generate type-safe getQueryData helpers
docs: replace ascii icons with svg

Fix #3747
This PR adds a config option to disable the generated
querySerializerobject in sdk functions.The generated
querySerializeroverrides the clientquerySerializerso it doen't allow to handle the serialization globally.