Skip to content

chore(web): format-gate the ungated first-party TS/JS (server/, vite.config.ts, scripts/) #1778

Description

@cliffhall

Summary

clients/web's format:check is scoped to src/ (prettier --check src), and the root format/format:check covers core/ plus each client's own scope. Nothing prettier-checks:

  • clients/web/server/** (Node dev/prod backend + Vite config helpers)
  • clients/web/vite.config.ts
  • scripts/*.mjs (root build/verify tooling)

So formatting in those files isn't gated by validate / CI. It's a pre-existing gap, surfaced repeatedly during the review of #1769 / PR #1777 — that PR alone adds a ~240-line scripts/verify-build-gate.mjs and a new clients/web/server/ module to the ungated set, and their quote/wrap style had to be matched to siblings by hand.

eslint already reaches wider (clients/web's lint is eslint ., and the root lint:core covers core/), so this is specifically about prettier coverage — though the two config surfaces should be reconciled together.

Proposal

Extend the format gate to cover the currently-ungated first-party TS/JS:

  • Widen clients/web's format / format:check beyond src/ to include server/, vite.config.ts (and any other top-level config it owns).
  • Add a root-level prettier scope for scripts/**/*.mjs (mirroring how format:core / lint:core gate core/), wired into validate:core or a new validate sub-step.
  • Run prettier --write once to normalize the newly-covered files, then confirm npm run validate / npm run ci stays green.

Notes

Metadata

Metadata

Assignees

Labels

v2Issues and PRs for v2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions