chore(typecheck): exclude standalone Expo example#28
Merged
Conversation
|
Claude finished @tolgahan-arikan's task —— View job PR Review: Exclude Expo Example from TypeScript Checking ✅Todo List:
Review Summary✅ LGTM - This is a clean, well-reasoned fix! AnalysisTypeScript Configuration Change:
Validation✅ Correctness of TypeScript API surface changes:
✅ API.md updates:
✅ Native layer consistency:
✅ Conventional Commits format:
✅ Alignment with project architecture:
Technical RationaleThis change addresses a real pain point where:
No Issues Found
RecommendationApprove and merge. This is a well-thought-out infrastructure fix that properly aligns the TypeScript configuration with the intended project architecture. |
taylanpince
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
examples/expo-exampleis intentionally outside the Yarn workspace, so rootyarn installdoes not install its npm dependencies. Without this exclusion, rootyarn typecheckcan fail on clean checkouts with missing Expo-only dependencies likeexpo-web-browser.Verification