fix: preserve custom name/description on SupervisorAgent

[nuthalapativarun]

Issue Link (REQUIRED)

Fixes #254

Summary

Changes

SupervisorAgent unconditionally overwrote options.name and options.description with the lead agent's values, even when the caller supplied their own. Changed both Python and TypeScript implementations to use the caller-provided values and fall back to the lead agent's values only when none were given.

Python (python/src/agent_squad/agents/supervisor_agent.py):

# before
options.name = options.lead_agent.name
options.description = options.lead_agent.description

# after
options.name = options.name or options.lead_agent.name
options.description = options.description or options.lead_agent.description

TypeScript (typescript/src/agents/supervisorAgent.ts):

// before
super({ ...options, name: options.leadAgent.name, description: options.leadAgent.description });

// after
super({ ...options, name: options.name ?? options.leadAgent.name, description: options.description ?? options.leadAgent.description });

User experience

Before: passing name="My Supervisor" to SupervisorAgentOptions had no effect — the name was replaced by the lead agent's name.

After: user-supplied name/description are preserved; the lead agent's values are used only as defaults when none are provided.

Checklist

• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• I have linked this PR to an existing issue (required)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[cornelcroi]

Hey @nuthalapativarun,

Three things need to be fixed before this can merge. First, the TypeScript change in supervisorAgent.ts has no test coverage — please add a test equivalent to what the Python side has in test_supervisor_agent.py (lines 105–120), confirming that a caller-supplied name is preserved and that the lead agent name is used as fallback when none is given. Second, Python uses or which treats an empty string "" as falsy and falls through to the lead agent name, while TypeScript uses ?? which only falls back on null/undefined — passing name="" would behave differently between the two implementations. They need to be aligned, either both use or/|| or both use ??? with an explicit empty-string check. Third, CI has not run — no checks are reported on this branch. All checks must pass before merge.

One smaller thing: the checklist says "Changes are documented" but there is no update in docs/ showing the new behaviour. Not a hard blocker if you decide no doc page covers this, but worth double-checking.

[nuthalapativarun]

Thanks for the review, @cornelcroi — addressed both points in 5eaa10e:

1. TS test added: typescript/tests/agents/SupervisorAgent.test.ts now mirrors test_supervisor_agent_preserves_custom_name_and_description from python/src/tests/agents/test_supervisor_agent.py (lines 105-120). It covers both the "custom name/description is preserved" case and the "empty name/description falls back to the lead agent's" case.
2. ?? vs or behavior aligned: changed the fallback in typescript/src/agents/supervisorAgent.ts from options.name ?? options.leadAgent.name / options.description ?? options.leadAgent.description to options.name || options.leadAgent.name / options.description || options.leadAgent.description, so an empty string now falls back to the lead agent's value just like Python's or.

Full TS jest suite passes locally (12 suites / 99 tests, including the new file), and tsc --noEmit is clean. Pushed to fix/254-supervisor-agent-name-desc. Ready for re-review whenever you get a chance.