fix(ci): use team ID for notarytool keychain profile name#1362
Merged
Conversation
Since #1337, APPLE_PERSONALID holds the full codesign identity string ("Developer ID Application: Erik Bjareholt (TEAMID)") derived from the imported certificate, instead of the short repo secret it used to be. notarize.sh used it unquoted as part of the notarytool keychain profile name, so the spaces word-split into stray arguments and every store-credentials/submit call failed: Error: 5 unexpected arguments: 'ID', 'Application:', 'Erik', ... Base the profile name on APPLE_TEAMID (no spaces) and quote the notarytool arguments. This was masked until now because the expired signing cert made the job fail before ever reaching notarization.
Member
Author
|
@greptileai review |
Contributor
Greptile SummaryThis PR fixes the macOS notarization profile used by release builds. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(ci): use team ID for notarytool keyc..." | Re-trigger Greptile |
Contributor
Greptile SummaryThis PR fixes the macOS notarization credential profile.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(ci): use team ID for notarytool keyc..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v0.14.0b2re-run (29498340371) got past signing after theCERTIFICATE_MACOS_P12_BASE64secret was rotated to the new 2025 Developer ID cert, but then failed in notarization:Since #1337,
APPLE_PERSONALIDis derived fromsecurity find-identityand holds the full identity string (Developer ID Application: Erik Bjareholt (TEAMID)) instead of the short repo secret it used to be.notarize.shused it unquoted as part of the notarytool keychain profile name, so the spaces word-split into stray arguments and everystore-credentials/submitcall failed. This was masked until now because the expired cert made the job fail before reaching notarization.Fix
APPLE_TEAMID(no spaces, stable) instead ofAPPLE_PERSONALID.notarytoolarguments inrun_notarytool.Context
Part of unblocking the v0.14.0b3 beta (see #1339 and the beta blocker tracker). The notarization path itself only runs on
v*tags, so CI here can't exercise it; verified the word-splitting logic locally.