Skip to content

fix(agentfield): add test for issue #587#775

Closed
jaythehardcoder wants to merge 1 commit into
Agent-Field:mainfrom
jaythehardcoder:fix/587-imageoutput-save-crashes-on-da
Closed

fix(agentfield): add test for issue #587#775
jaythehardcoder wants to merge 1 commit into
Agent-Field:mainfrom
jaythehardcoder:fix/587-imageoutput-save-crashes-on-da

Conversation

@jaythehardcoder

Copy link
Copy Markdown

What

Adds test coverage for the behavior described in issue #587.

Why

Fixes #587

Testing

  • New test added

Ref: Agent-Field#587
Signed-off-by: Jay <sallomondiei@gmail.com>

@santoshkumarradha santoshkumarradha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a pass at this. This needs to be turned into a real regression test before it’s mergeable.

Comment thread tests/test_issue_587.py
@@ -0,0 +1,3 @@
from agentfield.multimodal_response import ImageOutput

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is just executable snippet code at module import time, not a pytest test. Please move this into the package’s exercised test suite and add an assertion that reproduces the crash and proves the fix.

@jaythehardcoder

Copy link
Copy Markdown
Author

@santoshkumarradha thanks for taking a look — you're right that this needs to be a real pytest regression test rather than module-level executable code. I'll move it into the package's existing test infrastructure as a proper async test. Will push the update shortly.

@AbirAbbas

Copy link
Copy Markdown
Contributor

Closing as part of the cleanup of auto-generated "add test for issue #NNN" PRs from this account — see the notice on #762. These add placeholder/unverified test files to a root tests/ directory that this repo's CI does not collect, and they do not fix the referenced issues.

@AbirAbbas AbirAbbas closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImageOutput.save() crashes on data: URLs returned by Gemini image models

3 participants