fix(agentfield): add test for issue #586#776
Draft
jaythehardcoder wants to merge 1 commit into
Draft
Conversation
Ref: Agent-Field#586 Signed-off-by: Jay <sallomondiei@gmail.com>
santoshkumarradha
requested changes
Jul 15, 2026
santoshkumarradha
left a comment
santoshkumarradha
left a comment
Member
There was a problem hiding this comment.
Appreciate the follow-up here. This still needs to be wired up as an actual regression test.
| @@ -0,0 +1,10 @@ | |||
| from agentfield.vision import generate_image_openrouter | |||
| await generate_image_openrouter( | |||
Member
There was a problem hiding this comment.
Top-level await here is not a runnable pytest test, and the new top-level tests/ file is not the right place for the SDK coverage we rely on. Please add this under the exercised SDK test suite with an async test function and an assertion around the expected behavior.
Contributor
Author
|
@santoshkumarradha thanks for the follow-up — agreed it needs to be wired up as a proper regression test. I'll move the logic into the package's existing test suite as a proper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds test coverage for the behavior described in issue #586.
Why
Fixes #586
Testing