feat(Forms): Use CSS grid for form rows.#3996
Open
tvdeyen wants to merge 3 commits into
Open
Conversation
The compose setup failed in a few ways: pnpm install errored because the image copied only pnpm-lock.yaml, leaving pnpm-workspace.yaml (and its allowBuilds entry) out of the build; the listen gem flooded boot with "already being watched" warnings; dependencies could drift from the shared source since gems and node_modules were baked once into the image; and the web service refused to boot whenever a stale tmp/pids/server.pid was left behind on the shared mount. Copy pnpm-*.yaml so the workspace config is present, silence the listen warnings, add a one-shot deps service with a shared bundle volume so gems and node_modules are reinstalled against the current lockfiles on every up, and have the web command clear a stale pidfile and exec the server so it receives SIGTERM and shuts down cleanly.
The nodeLinker: hoisted setting was an earlier attempt to stop Rails' evented file watcher (listen gem) from warning about directories being watched through two paths. It doesn't actually help: pnpm keeps its .pnpm symlink store regardless of the layout, so listen still follows those symlinks and warns. Revert to pnpm's default layout and instead silence the warning at its source via LISTEN_GEM_ADAPTER_WARN_BEHAVIOR on the two Rails processes (web and dartsass:watch) in the dummy app's dev Procfile. The admin sourcemap changes accordingly because dependency sources now resolve through .pnpm store paths under the default layout; the bundle itself is byte-for-byte unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 346 346
Lines 8974 8974
=======================================
Hits 8806 8806
Misses 168 168 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Instead of a float based layout that made it necessary to have a clearfix and add every single potential input / component that goes into the second column into a CSS selector we use the very much established CSS grid now. Most changes are deletions, but some quirks were necessary, but all of them make very much sense. This changes the label/input ratio from 0.35 / 1.65 to 1 / 2.25 in order to make more room for inputs and components and still keep the label wide enough.
tvdeyen
force-pushed
the
use-css-grid-for-forms
branch
from
c890f51 to
2071ad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of a float based layout that made it necessary to
have a clearfix and add every single potential input / component
that goes into the second column into a CSS selector we use
the very much established CSS grid now.
Most changes are deletions, but some quirks were necessary, but
all of them make very much sense.
Notable changes
This changes the label/input ratio from 0.35 / 1.65 to 1 / 2.25
in order to make more room for inputs and components and still keep
the label wide enough.
Screenshots
Checklist