fix(LocaleSelect): Use request.path instead of helpers.url_for#3997
Merged
Conversation
tvdeyen
approved these changes
Jun 19, 2026
tvdeyen
left a comment
tvdeyen
left a comment
Member
There was a problem hiding this comment.
Ha! Thanks :) Would you mind to squash the test commit into the actual fix? Thanks 🙏🏻
This fixes an adjacent bug to AlchemyCMS#3974 - I didn't find this in my repro at the time as this is only shown when more than one locale is used. I've grepped through the code and at least in the view components there don't seem to be any other usages of the argless `url_for` If you want to take a look, I've updated [my repro](https://github.com/halfbyte/alchemy_repro).
halfbyte
force-pushed
the
another-url-for
branch
from
2d063da to
58d8a6a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 346 346
Lines 8974 8974
=======================================
Hits 8806 8806
Misses 168 168 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This fixes an adjacent bug to #3974 - I didn't find this in my repro
at the time as this is only shown when more than one locale is used.
I've grepped through the code and at least in the view components there
don't seem to be any other usages of the argless
url_forIf you want to take a look, I've updated my repro.
Notable changes (remove if none)
Uses
request.pathinstead of an arglessurl_forto get the URL path for the current page for the form action URL in the component.Checklist