Skip to content

[PWGLF] readded photon selection of e+- and improved pi0 selection#16944

Open
GiorgioAlbertoLucia wants to merge 2 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:its_new
Open

[PWGLF] readded photon selection of e+- and improved pi0 selection#16944
GiorgioAlbertoLucia wants to merge 2 commits into
AliceO2Group:masterfrom
GiorgioAlbertoLucia:its_new

Conversation

@GiorgioAlbertoLucia

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwglf label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 75 errors, ⚠️ 102 warnings, 🔕 0 disabled

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 9046f04 at 2026-07-07 15:22:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 8 errors and 55 warnings.'
Found 8 errors and 55 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/a079b29444c77f74091a00cefb460747d90b034b/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:78:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:148:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:166:8: error: constructor does not initialize these fields: m_ccdb, m_runNumber, m_d_bz, m_BBparamsDe, m_BBparamsHe [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:254:92: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:337:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:399:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:691:14: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:723:43: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
++ [[ 55 -gt 0 ]]
++ cat /sw/BUILD/a079b29444c77f74091a00cefb460747d90b034b/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:344:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:346:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:348:66: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:350:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:352:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:360:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:362:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:364:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:366:50: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:368:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:370:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:378:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:380:75: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:382:74: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:384:85: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:386:73: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:388:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:390:78: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:392:61: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:394:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:398:79: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:424:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:426:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:428:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:437:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:439:128: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:441:39: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:570:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:703:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:707:72: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:751:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:787:47: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Fix calculation of mass for Pi0 particles in analysis.
@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 35b1c47 at 2026-07-07 16:42:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ';' before ')' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 35b1c47 at 2026-07-07 16:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ';' before ')' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 35b1c47 at 2026-07-07 16:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/LFTreeCreatorClusterStudies.cxx:1126:143: error: expected ';' before ')' token
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants