Skip to content

[PWGCF] Fixed logic of multiplicity based selection in mixed events#16945

Open
Preet-Bhanjan wants to merge 2 commits into
AliceO2Group:masterfrom
Preet-Bhanjan:master
Open

[PWGCF] Fixed logic of multiplicity based selection in mixed events#16945
Preet-Bhanjan wants to merge 2 commits into
AliceO2Group:masterfrom
Preet-Bhanjan:master

Conversation

@Preet-Bhanjan

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@Preet-Bhanjan Preet-Bhanjan marked this pull request as ready for review July 7, 2026 13:07
@alibuild

alibuild commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4fcf97d at 2026-07-07 15:25:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 93 errors and 191 warnings.'
Found 93 errors and 191 warnings.
++ [[ 93 -gt 0 ]]
++ cat /sw/BUILD/1b0a31b84c3a7421844b7e1f03a1f6c3b8b035ee/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:68:78: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:69:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:70:18: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:72:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:103:71: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:158:59: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:213:35: error: initializer for member 'cstFT0RelGain' is redundant [readability-redundant-member-init,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:351:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:357:52: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:359:53: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:362:50: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:364:51: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:367:55: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:369:56: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:372:54: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:374:55: error: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:376:9: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:507:23: error: redundant call to 'c_str' [readability-redundant-string-cstr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:516:11: error: variable 'cent' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:843:27: error: the parameter 'track' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:854:10: error: variable 'isPion' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:854:18: error: variable 'isKaon' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:854:26: error: variable 'isProton' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:865:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:906:40: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:909:23: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:919:43: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:922:26: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:932:46: error: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:994:29: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1015:29: error: the parameter 'collision' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1015:48: error: the parameter 'tracks' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1043:35: error: the parameter 'track1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1045:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1095:34: error: the parameter 'track1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1097:5: error: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1147:39: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1150:24: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1234:24: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1278:33: error: the parameter 'tracks1' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1278:55: error: the parameter 'tracks2' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/corrFit.cxx:1281:24: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants