[PWGHF] Fix MC flagging for c-deuteron#16953
Merged
Merged
Conversation
fgrosa
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Collaborator
Collaborator
|
Error while checking build/O2Physics/staging for 5795b0e at 2026-07-07 17:11: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 5795b0e at 2026-07-07 17:12: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 5795b0e at 2026-07-07 17:16: Full log here. |
vkucera
reviewed
Jul 7, 2026
Comment on lines
+163
to
+165
| static const std::array<int, 2> statusCodeCDeuteronToDeKstar0{-85, -95}; | ||
| static const std::array<int, 2> statusCodeCDeuteronToNeDeltaplusK{-86, -96}; | ||
| static const std::array<int, 2> statusCodeCDeuteronToNeL1520Pi{-87, -97}; |
Collaborator
There was a problem hiding this comment.
These used to be constexpr constants. Why are they not any more?
Collaborator
Author
There was a problem hiding this comment.
I thought it was not necessary to have them constexpr in first place, but if you want I can revert them. What about all the other variables that are const (the maps)? Is there any advantage of having them constexpr?
Collaborator
There was a problem hiding this comment.
I thought it was not necessary to have them
constexprin first place, but if you want I can revert them.
Yes, please.
What about all the other variables that are
const(the maps)? Is there any advantage of having themconstexpr?
I don't remember if they can be constexpr but if yes, it would be better for compile-time checks and optimisations. I will check later.
Collaborator
Author
There was a problem hiding this comment.
Apparently unordered_map cannot be constexpr in C++17 / C++20 / C++23
Collaborator
|
Error while checking build/O2Physics/code-check for d6b4b86 at 2026-07-07 17:47: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for fcc840e at 2026-07-07 18:44: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zhangbiao-phy