[HorizonDB] Add parameter-group commands#10046
Open
alxhghs wants to merge 11 commits into
Open
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| horizondb parameter-group | sub group horizondb parameter-group added |
alxhghs
force-pushed
the
alexfen-horizondb-parameter-group-commands
branch
2 times, most recently
from
June 26, 2026 21:34
6614ae0 to
dbf90a9
Compare
Add 'az horizondb parameter-group' command group over the Microsoft.HorizonDb/parameterGroups resource with create, delete, list, and show commands. Parameter groups are immutable once created (service returns ParameterGroupUpdateNotSupported), so no update command is provided. Bump version to 1.0.0b4. Includes live-recorded test cassette and test run log. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alxhghs
force-pushed
the
alexfen-horizondb-parameter-group-commands
branch
from
June 26, 2026 21:46
dbf90a9 to
a86d6de
Compare
Collaborator
|
HorizonDB |
nasc17
reviewed
Jun 29, 2026
nasc17
reviewed
Jun 29, 2026
nasc17
reviewed
Jun 29, 2026
nasc17
reviewed
Jun 29, 2026
nasc17
suggested changes
Jun 29, 2026
- Move parameter-group commands into commands/parameter_group_commands.py - Reword parameter-group create help for unspecified parameters - Clarify --version help as the PostgreSQL major version - Remove committed test_horizondb_results.log Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds HorizonDB parameter-group management support to the horizondb extension, including new CLI commands, argument wiring/validation, help text, and scenario coverage, along with a version bump and history entry.
Changes:
- Introduces
az horizondb parameter-group {create,show,list,delete}command group wired to the vendored SDK plus custom create/delete/list handlers. - Adds
--parametersparsing/validation and new help entries for the parameter-group commands. - Adds/extends scenario tests for parameter-group CRUD and bumps extension version + HISTORY.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/horizondb/setup.py | Bumps extension version to 1.0.0b4. |
| src/horizondb/HISTORY.rst | Documents the new parameter-group command set in release notes. |
| src/horizondb/azext_horizondb/tests/latest/test_horizondb_parameter_group.py | Adds CRUD scenario coverage for parameter groups and extends existing scenario flows. |
| src/horizondb/azext_horizondb/tests/latest/constants.py | Adds naming constants for parameter-group test resources. |
| src/horizondb/azext_horizondb/commands/parameter_group_commands.py | Implements custom handlers for create/delete/list (with no-wait support). |
| src/horizondb/azext_horizondb/cluster_commands.py | Registers the new horizondb parameter-group command group and its commands. |
| src/horizondb/azext_horizondb/_validators.py | Adds a validator to parse --parameters name=value pairs into SDK model objects. |
| src/horizondb/azext_horizondb/_params.py | Adds CLI argument definitions for parameter-group commands (name, parameters, pg-version, etc.). |
| src/horizondb/azext_horizondb/_help.py | Adds CLI help entries and examples for the new parameter-group commands. |
| src/horizondb/azext_horizondb/_client_factory.py | Adds a client factory for parameter-group operations. |
nasc17
reviewed
Jun 30, 2026
nasc17
reviewed
Jun 30, 2026
nasc17
suggested changes
Jun 30, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Remove the redundant pg_version_arg_type and reuse version_arg_type (--version/-v) for the parameter group create command, per review feedback. Update help examples and tests accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nasc17
approved these changes
Jun 30, 2026
nasc17
left a comment
nasc17
left a comment
Member
There was a problem hiding this comment.
Looks good, address merge conflict
…arameter-group-commands # Conflicts: # src/horizondb/HISTORY.rst # src/horizondb/azext_horizondb/_params.py
nachoalonsoportillo
left a comment
nachoalonsoportillo
left a comment
Member
There was a problem hiding this comment.
I'm missing one command through which we can list connections (https://learn.microsoft.com/en-us/rest/api/horizondb/parameter-groups/list-connections?view=rest-horizondb-2026-01-20-preview&tabs=HTTP)
`az horizondb parameter-group list-connections'
…d' of https://github.com/nachoalonsoportillo/azure-cli-extensions into nacho-horizondb-parameter-group-list-connections-command
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Pan-Qi
requested changes
Jul 10, 2026
Pan-Qi
left a comment
Pan-Qi
left a comment
Contributor
There was a problem hiding this comment.
Please try to sync with main branch, then I will re-run the test to see if the test pass.
…oup argument description
…arameter-group-commands # Conflicts: # src/horizondb/HISTORY.rst # src/horizondb/azext_horizondb/_client_factory.py # src/horizondb/azext_horizondb/_help.py # src/horizondb/azext_horizondb/_params.py # src/horizondb/azext_horizondb/cluster_commands.py # src/horizondb/azext_horizondb/utils/validators.py
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 10046 in repo Azure/azure-cli-extensions |
Member
Author
|
Hi @Pan-Qi, I merged main if you don't mind running the tests again |
…horizondb-parameter-group-list-connections-command
…ter-group-list-connections-command [HorizonDB] Add list-connections command to the parameter-group group
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
nachoalonsoportillo
approved these changes
Jul 14, 2026
nachoalonsoportillo
suggested changes
Jul 15, 2026
nachoalonsoportillo
left a comment
nachoalonsoportillo
left a comment
Member
There was a problem hiding this comment.
Should also update VERSION in setup.py.
|
|
||
| 1.0.0b5 | ||
| +++++++ | ||
| * Add `az horizondb parameter-group` commands to create, delete, list, and show HorizonDB parameter groups. |
Member
There was a problem hiding this comment.
I saw that on the PR which adds support for restore commands you bumped version to 1.0.0b6. Will this one go after with version 1.0.0b7?
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
az horizondb parameter-groupcommands to manage HorizonDB parameter groups:parameter-group create— create a parameter group. The service requires at least one customname=valueparameter (--parameters); any parameters you do not specify inherit the PostgreSQL defaults for the group.parameter-group show— show a parameter groupparameter-group list— list parameter groups in a resource groupparameter-group delete— delete a parameter groupparameter-group list-connections- list clusters to which the parameter group is connected toParameter groups are immutable once created (the service rejects updates), so no
updatecommand is provided; to change parameters, create a new group and assign it to the cluster viaaz horizondb update --parameter-group.Bumps the extension version to
1.0.0b4and documents the change in HISTORY.rst.Testing
azdev style horizondb— PASSEDazdev linter horizondb— PASSEDHorizonDBParameterGroupCrudScenarioTestrecorded live and verified in playback — PASSEDHistory Notes
az horizondb parameter-groupcommands to create, delete, list, and show HorizonDB parameter groups.