Add microsoft.virtualnodes to the list of allowed extension types.#10091
Add microsoft.virtualnodes to the list of allowed extension types.#10091tomaandreisacuiu wants to merge 2 commits into
microsoft.virtualnodes to the list of allowed extension types.#10091Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
This PR updates the aks-preview extension to allow microsoft.virtualnodes as an accepted Kubernetes extension type, and bumps the extension version to publish that change.
Changes:
- Add
microsoft.virtualnodesto the extension-type allow list used byaz aks extensionvalidation. - Bump
aks-previewextension version from21.0.0b8to21.0.0b9. - Record the change in
HISTORY.rstfor the new version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/_helpers.py | Extends the allow list to include microsoft.virtualnodes for extension-type validation. |
| src/aks-preview/setup.py | Bumps the extension package version to 21.0.0b9. |
| src/aks-preview/HISTORY.rst | Adds the 21.0.0b9 changelog entry describing the allow-list update. |
| # type variables | ||
| ManagedCluster = TypeVar("ManagedCluster") | ||
| allowed_extensions = ["microsoft.dataprotection.kubernetes"] | ||
| allowed_extensions = ["microsoft.dataprotection.kubernetes", "microsoft.virtualnodes"] |
|
AKS |
FumingZhang
left a comment
There was a problem hiding this comment.
Could you expand the PR description with a bit of context on microsoft.virtualnodes — what this extension does and why it's being added to the allow-list now? A link to the extension type docs / onboarding issue would also help future readers understand the intent. If there's a customer-facing usage flow (e.g. the az aks extension create ... --extension-type microsoft.virtualnodes command), a one-line example in the description would be great too.
|
@tomaandreisacuiu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
If this is not applicable, please add a new scenario test case to make sure the new extension could work as expected. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.