[StorageMover] Assign identity to S3 HMAC endpoint creation#10096
Open
sssash18 wants to merge 3 commits into
Open
[StorageMover] Assign identity to S3 HMAC endpoint creation#10096sssash18 wants to merge 3 commits into
sssash18 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cab812cd-ce68-400e-95d4-9cd71f5f4805
️✔️Azure CLI Extensions Breaking Change Test
|
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the storage-mover extension to assign a system-assigned managed identity when creating an S3WithHMAC endpoint (az storage-mover endpoint create-for-s3-with-hmac), aligning its behavior with the existing storage-container endpoint creation logic. It also adds a small unit test to validate the new argument wiring and bumps the extension patch version.
Changes:
- Set
mi_system_assigned = "True"duringendpoint_create_for_s3_with_hmacso the endpoint is created with a system-assigned identity. - Add a focused unit test asserting the
mi_system_assignedargument is passed to the generatedCreatecommand. - Bump extension version to
1.3.1and add a correspondingHISTORY.rstentry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/storage-mover/setup.py | Bumps the extension version to 1.3.1. |
| src/storage-mover/HISTORY.rst | Documents the 1.3.1 change in release notes. |
| src/storage-mover/azext_storage_mover/tests/latest/test_storage_mover_unit.py | Adds unit coverage ensuring system identity is passed for S3-with-HMAC endpoint creation. |
| src/storage-mover/azext_storage_mover/custom.py | Applies system-assigned identity flag during S3-with-HMAC endpoint creation. |
Collaborator
|
StorageMover |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cab812cd-ce68-400e-95d4-9cd71f5f4805
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 10096 in repo Azure/azure-cli-extensions |
Member
Author
|
@Pan-Qi , merged main into PR branch to fix failing pipelines |
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
|
@sssash18 please re-record tests and fix the linting issue |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f8279c95-dd94-46c7-a050-595f463e7abe
Member
Author
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az storage-mover endpoint create-for-s3-with-hmacDescription
Testing
python -m pytest -q test_storage_mover_unit.py test_storage_mover.py::StorageMoverScenario::test_storage_mover_endpoint_s3_with_hmac_scenariosazdev style storage-moverpython scripts/ci/test_index.py -qGeneral Guidelines
azdev style storage-moverlocally?python scripts/ci/test_index.py -qlocally?