Fix typos reported in issue #115#136
Open
ZayanKhan-12 wants to merge 1 commit into
Open
Conversation
- inital -> initial in the SInitData comment in the generated protocol files (comment-only; the same typo also appears in files generated after the issue was filed, so the generator template presumably still carries it) - hexidecimal -> hexadecimal, represpentation -> representation and prcess_event -> process_event (comment; the function is named process_event) in s2_cli.py - matchng -> matching in versions/__init__.py - completness -> completeness in docs/events.rst Fixes Blizzard#115 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
Applies the typo fixes @timgates42 catalogued in #115 (the issue invited anyone to open the PR):
inital→initialin theNNet.Replay.SInitDatacomment across the generated protocol files — comment-only, no identifiers or data touched. Notably the typo also appears in protocol files added after the issue was filed (92 files total vs 74 in the issue), so the generator template presumably still carries it upstream.hexidecimal→hexadecimal,represpentation→representation, andprcess_event→process_event(comment; the function is namedprocess_event) ins2protocol/s2_cli.pymatchng→matchingins2protocol/versions/__init__.pycompletness→completenessindocs/events.rstVerification
py_compilepasses on all changed Python filesimpissue — Python 3.12: remove imp dependency #130 / PRs Migrate _import_protocol to importlib #126, missing module and use importlib #135)🤖 Generated with Claude Code