Migrate error rendering to ariadne#370
Merged
LesterEvSe merged 1 commit intoJul 17, 2026
Merged
Conversation
LesterEvSe
force-pushed
the
feat/ariadne-diagnostic
branch
from
July 13, 2026 11:44
9a6a4ba to
3018a7b
Compare
Closed
Collaborator
|
Couple of CI issues |
LesterEvSe
force-pushed
the
feat/ariadne-diagnostic
branch
from
July 13, 2026 11:59
3018a7b to
6344c99
Compare
LesterEvSe
marked this pull request as draft
July 13, 2026 11:59
LesterEvSe
force-pushed
the
feat/ariadne-diagnostic
branch
4 times, most recently
from
July 13, 2026 12:41
3840f72 to
609133f
Compare
LesterEvSe
marked this pull request as ready for review
July 13, 2026 12:55
LesterEvSe
force-pushed
the
feat/ariadne-diagnostic
branch
12 times, most recently
from
July 16, 2026 13:58
9577381 to
6b5a7b6
Compare
KyrylR
reviewed
Jul 17, 2026
LesterEvSe
force-pushed
the
feat/ariadne-diagnostic
branch
from
July 17, 2026 08:49
6b5a7b6 to
7a0818d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
ariadne.RichErrorwithDiagnostic, which carries all the information needed for error rendering.ErrorCollectortoDiagnosticManagerand give it ownership ofSourceMap.WithContentandWithSourcetraits. No longer needed.