Feat/offer cancellation#115
Open
zahorodnyi wants to merge 2 commits into
Open
Conversation
zahorodnyi
force-pushed
the
feat/offer-cancellation
branch
2 times, most recently
from
July 15, 2026 12:21
cbddee0 to
a239477
Compare
zahorodnyi
force-pushed
the
feat/offer-cancellation
branch
from
July 15, 2026 13:00
a239477 to
950b908
Compare
zahorodnyi
force-pushed
the
feat/offer-cancellation
branch
from
July 16, 2026 08:12
950b908 to
8b99f84
Compare
Hrom131
reviewed
Jul 16, 2026
Comment on lines
+255
to
+259
| transaction.add_output(PartialOutput::new( | ||
| self.signer().get_address().script_pubkey(), | ||
| parameters.offer_parameters.collateral_amount, | ||
| parameters.collateral_asset_id, | ||
| )); |
Collaborator
There was a problem hiding this comment.
Let's use confidential output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds offer cancellation flow and tests for new logic in lending-session crate