split challenge.py into generic properties#214
Open
vellvoid wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
this builds on #213 to avoid conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core/challenge.pyhas become the designated place for most of ctfcli's most-important functionality (managing challenges). Adding a new property to the challenge requires touching multiple places and further stuffing of that file - the architecture is just not scalable.This PR introduces a concept of properties - each challenge property like flags, topics, files, name etc. is handled within its own class which knows how to install, sync, compare, pull that specific property. The challenge class just calls hooks for all known properties.
Adding a new property boils down to creating a new class (or using a generic one for simple properties like just a string), and registering it with the properties registry.