Add FreeBSD platform support#204
Open
elliejs wants to merge 1 commit into
Open
Conversation
5 tasks
Author
|
I have no idea why that OSX 3.11 job failed. Clang itself segfaulted, it didn't even emit an error, so I think it's unrelated to this change. In my own fork (which also has my own forked pywrap, so slightly different), this check passes. pywrap sister PR here: CadQuery/pywrap#62 action run with passing osx 3.11 here: https://github.com/elliejs/OCP/actions/runs/28189561694/job/83530983484 |
Add build-job-freebsd.yml CI workflow for generating and compiling OCP bindings on FreeBSD 15.0 using vmactions/freebsd-vm. FreeBSD has no conda-forge packages, so all dependencies come from the FreeBSD pkg system (latest repo). The workflow follows the same two-phase structure (generate → compile) as the other platforms, with source caching between phases and a combined sources+stubs artifact upload. The clang Python bindings are pip-installed because the FreeBSD pkg version (11.0) is too old to drive libclang 22 from llvm-devel. Add a [FreeBSD] platform section to ocp.toml with system include paths and a FreeBSD symbol manifest. Add `using` declarations (include_header_pre) for 13 nested C++ types across 11 modules (Standard, OSD, Aspect, SelectMgr, AIS, Graphic3d, BRepGProp, ShapeProcess, BOPAlgo, Message, IntPatch, HLRAlgo) — FreeBSD's clang resolves these nested types (e.g. Standard_MMgrOpt::TPCallBackFunc, HLRAlgo_PolyData::Box) to a different canonical form than other platforms, so pybind11 needs explicit forward declarations to bind them. Update dump_symbols.py to support lief <0.14 (FreeBSD pkg ships 0.12.3), which uses lief.EXE_FORMATS instead of lief.Binary.FORMATS. The existing code used p.FORMATS which only works on 0.14+. The fallback (getattr + or) now supports both. Also reorder the lief.parse() None check before accessing p.format (was a crash on parse failure), add an empty-string guard for the semicolon-split lib list, and detect FreeBSD as a distinct ELF platform via platform.system(). Add FreeBSD case to CMakeLists.txt platform detection and FreeBSD job entry to bindings.yml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
yeah I only changed the commit message but it all passes now, yay |
Member
|
I would expect no changes needed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-job-freebsd.ymlCI workflow for FreeBSD 15.0 usingvmactions/freebsd-vm, with all dependencies from FreeBSDpkg(no conda-forge packages exist for FreeBSD). Follows the same two-phase generate/compile structure as the other platforms.[FreeBSD]platform section toocp.tomlwith system include paths andusingdeclarations for 13 nested C++ types that FreeBSD's clang resolves differently than other platforms.dump_symbols.pyfor lief <0.14 compatibility (lief.EXE_FORMATSfallback), fix a crash whenlief.parse()returnsNone, and detect FreeBSD as a distinct ELF platform.CMakeLists.txtplatform detection and job entry tobindings.yml.Notes
py311-clang11.0) is too old to drivelibclang 22fromllvm-devel.Test plan
import OCPtest passes in CI🤖 Generated with Claude Code