Fix auto-tap highlight never showing#11339
Open
autumnmyst wants to merge 1 commit into
Open
Conversation
tool4ever
reviewed
Jul 23, 2026
autumnmyst
force-pushed
the
fix-autotap-highlight
branch
from
July 24, 2026 17:11
6b4b8c6 to
8af375a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-tap highlight never appeared because
getManaSourcesToPayCostread its cards from aList<Mana>that atest=truepayment never populates (test mode only predicts the mana produced and records the chosen abilities) so it always returned an empty set and no card reached the strength-2 threshold the highlight requires. This threads the chosen mana abilities out ofpayManaCostso their host cards are reported, and draws the glow after the actionable highlight so it stays visible when black borders are disabled, where that highlight is an outset that otherwise covers it.EDIT: now after rebase this PR only changes the visuals for more clarity by making the boarder highlight the same yellow as the glow for visual clarity.