Add Adventure settings option to start directly in Adventure mode#11346
Closed
liminalwarmth wants to merge 1 commit into
Closed
Add Adventure settings option to start directly in Adventure mode#11346liminalwarmth wants to merge 1 commit into
liminalwarmth wants to merge 1 commit into
Conversation
Contributor
Author
|
If this is considered unnecessary because the option technically already existed in the app's top-level options menu, no sweat. I just didn't even realize that it was there until after I had added this feature, because I never dug into that part of the app or realized that that option was available since it didn't exist on the settings I had been looking at. |
Contributor
Author
|
I think I actually would prefer to handle this by mirroring the selector mode dropdown from the standard settings menu rather than adding a new checkbox. Closing this for now, and I'm going to come back with a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11344: adds an option inside Adventure Mode's settings to start Forge directly in Adventure Mode.
Why
Adventure Mode fully supports controller navigation, but the mode-selector splash screen shown at startup does not. Players who primarily play Adventure with a controller must reach for the mouse on every launch just to get into the mode they always play. Forge already has a preference for this (
UI_SELECTOR_MODE, exposed as "Selector Mode" in the classic mobile settings page), but it is not reachable from within Adventure Mode itself.What
Adds a "Start in Adventure mode (applies on next launch)" checkbox to Adventure's Settings scene, right below the World selector:
UI_SELECTOR_MODEtoAdventure, so the next launch boots straight into the Adventure main menu (fully controller-navigable).Default, bringing back the mode-selector splash screen — so switching back to other modes stays easy, per the issue discussion.Forge.selectoris updated immediately, matching how the classicSettingsPageapplies the same preference.No new preference is introduced — this only exposes the existing
UI_SELECTOR_MODEpreference where controller players need it.Changes
forge-gui-mobile/src/forge/adventure/scene/SettingsScene.java: new checkbox wired toUI_SELECTOR_MODE; the booleanaddSettingFieldoverload now returns itsCheckBoxso the setting can be refreshed on enter.forge-gui/res/languages/en-US.properties: newlblStartInAdventureModestring.Primary feature was written with Codex 5.6 Sol with guidance to scope it as small as possible, code reviewed in several rounds by Sol and Claude Fable, and manually tested (by me on MacOS) before opening the PR.
Testing
mvn -pl forge-gui-mobile -am compilepasses on this branch.