Discard: fix discardedMap#11376
Merged
Merged
Conversation
tool4ever
reviewed
Jul 25, 2026
Contributor
Author
|
I'm more confused on how a Null might get in there, but i left the check there |
tool4ever
approved these changes
Jul 25, 2026
tool4ever
left a comment
tool4ever
left a comment
Contributor
There was a problem hiding this comment.
if only we had some Map interface that doesn't offer mutable methods to enforce it at compile time :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Connive/Recruit problem with Immutable Map
instead, create a new Map for Discarded cards