Speed up ASMDataTable.getAnnotationsFor (O(n^2) -> O(n))#582
Merged
Conversation
Member
|
Well known fix that can be pulled in, but a word of warning is that this will likely be redundant as the cleanmix branch may override this |
Rongmario
approved these changes
Jul 2, 2026
baka-gourd
pushed a commit
that referenced
this pull request
Jul 17, 2026
- It is likely that ASMDataTable + the class scanner will be rewritten at a later date!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while profiling a ~200-mod pack's startup with flare:
getAnnotationsForwas re-filtering the entire annotation table once per mod (Guava'sMultimaps.filterValues+ImmutableSetMultimap.copyOfre-scanning everything on every call), which added up to ~19s of CPU time during preInit for no real reason.Swapped it for a single grouping pass over the annotation table, then an O(1) lookup per container - same equality check as before (
FilefromModContainer.getSource()), just done once instead of once-per-mod. Same caching, same public behavior.Before flare profiles:
After: