feat(gradebook): external assessments with bounded grades and CSV import#8456
Open
LWS49 wants to merge 1 commit into
Open
feat(gradebook): external assessments with bounded grades and CSV import#8456LWS49 wants to merge 1 commit into
LWS49 wants to merge 1 commit into
Conversation
16ea8b5 to
1c5b845
Compare
1f15ebc to
441d043
Compare
…ation, inline grade entry) Foundation layer for external assessments: data model + migrations, gradebook read serialization, and inline grade entry (update_grade). Management UI (panel, add/edit/delete), weight integration, and CSV import are introduced in later PRs of the stack.
441d043 to
aeb0e66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds external assessments to the gradebook, the only gradebook columns a professor can create, edit, and delete, on top of the weighted gradebook view (#8436). Each external assessment carries optional floor/cap bound flags, ships with a CSV grade-import core, and stores grades at
decimal(5,2)so two-decimal imports (Canvas, SoftMark) round-trip without silent rounding. Also adds thematerializedDefaultWeightshelper, so a later mutating action that sets a real weight while the equal-split default is showing can freeze that split first (wired up in the next PR).Design decisions
decimal(5,2); native grade columns staydecimal(4,1)- externals are fed by Canvas/SoftMark which emit two decimals, while native grading is Coursemology-native where one decimal is fine. Widening every grade column would be a larger, separate change.effectiveGrade), never mutating the stored grade - the raw "All assessments" view always shows the true entered value, and toggling a flag re-interprets rather than rewrites data.Regression prevention
Covers: external assessment column-id building, the external assessment and external grade models, store/operations reducers, the import wizard, gradebook table rendering, and the new
materializedDefaultWeightshelper (frontend suites green - 262 tests). Migrations (20260615create external tables,20260616link externals to contributions,20260622bounds,20260623decimal(5,2)precision) are reversible. Ruby model/controller specs run on push/CI.