Skip to content

Chrome: Up chrome #33907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vorobey wants to merge 6 commits into
base: 26_1
Choose a base branch
from
Open

Chrome: Up chrome #33907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4d4bbe
Chrome: Up chrome to 149
Jun 8, 2026
afb457b
TestCafe tests: await timeout debug
Jun 11, 2026
75d27a0
TestCafe tests: add debug
Jun 12, 2026
5bb7e54
TestCafe tests: remove debug due its verbose
Jun 12, 2026
8078d1e
TestCafe tests: add targeted JS error
Jun 12, 2026
0cdcef9
Chrome: remove await
Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/playgrounds_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-testcafe-on-gh-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Setup Chrome
uses: ./devextreme/.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- uses: pnpm/action-setup@v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testcafe_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ jobs:
# - name: Setup Chrome
# uses: ./.github/actions/setup-chrome
# with:
# chrome-version: '145.0.7632.67'
# chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/visual-tests-demos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down Expand Up @@ -735,7 +735,7 @@ jobs:
STRATEGY: ${{ matrix.STRATEGY }}
CHANGEDFILEINFOSPATH: changed-files.json
BROWSERS: ${{ steps.chrome-flags.outputs.flags }}
#DEBUG: hammerhead:*,testcafe:*
# DEBUG: hammerhead:*,testcafe:*
CONCURRENCY: 4
TCQUARANTINE: true
CONSTEL: ${{ matrix.CONSTEL }}
Expand Down Expand Up @@ -821,7 +821,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down Expand Up @@ -951,7 +951,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down Expand Up @@ -1131,7 +1131,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down Expand Up @@ -1203,7 +1203,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wrapper_tests_e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
- name: Setup Chrome
uses: ./.github/actions/setup-chrome
with:
chrome-version: '145.0.7632.67'
chrome-version: '149.0.7827.53'

- name: Use Node.js
uses: actions/setup-node@v6
Expand Down
22 changes: 22 additions & 0 deletions apps/demos/utils/visual-tests/matrix-test-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,22 @@ export function runManualTestCore(
const testStyles = getTestStyles(demo);

const clientScripts = [
{
content: `
window.__dxTestErrors = [];
window.addEventListener('error', function(e) {
window.__dxTestErrors.push({
message: e.message,
filename: e.filename,
lineno: e.lineno,
colno: e.colno,
targetTag: e.target && e.target.tagName,
targetSrc: e.target && (e.target.src || e.target.href),
});
console.error('[DX-TEST-JS-ERROR]', JSON.stringify(window.__dxTestErrors[window.__dxTestErrors.length - 1]));
}, true);
`,
},
{ module: 'mockdate' },
join(__dirname, './inject/test-utils.js'),
{ content: injectStyle(globalReadFrom(__dirname, './inject/test-styles.css', (x) => x)) },
Expand All @@ -325,6 +341,12 @@ export function runManualTestCore(
.page(testURL);

test.before?.(async (t) => {
const consoleMsgs = await t.getBrowserConsoleMessages();
const dxErrors = consoleMsgs.error.filter((m: string) => m.includes('[DX-TEST-JS-ERROR]'));
if (dxErrors.length > 0) {
console.log('[DX-BROWSER-ERRORS]', dxErrors.join('\n'));
}

if (testCodeSource) {
await execCode(testCodeSource);
}
Expand Down
11 changes: 9 additions & 2 deletions apps/demos/utils/visual-tests/testcafe-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,15 @@ async function main() {
.concurrency(concurrency || 1)
.run({
quarantineMode: getQuarantineMode(),
skipJsErrors: (err) => {
if (err?.message === 'Script error.') {
// Skip to allow test.before to run and dump browser console details
console.log('[DX-SKIP-SCRIPT-ERROR] page:', err?.pageUrl);
return true;
}
console.log('[DX-PAGE-JS-ERROR]', JSON.stringify({ message: err?.message, pageUrl: err?.pageUrl }));
return false;
},
// @ts-expect-error ts-error
hooks: {
test: {
Expand All @@ -111,8 +120,6 @@ async function main() {
}
window.getSelection()?.removeAllRanges();
}).with({ boundTestRun: t })();

await t.hover('html', { offsetX: 1, offsetY: 1 });
},
},
},
Expand Down
Loading