Skip to content

[ENG-1852] Keep Roam shared node content fresh#1147

Open
sid597 wants to merge 1 commit into
mainfrom
eng-1852-keep-roam-shared-node-content-fresh-in-the-sync-loop
Open

[ENG-1852] Keep Roam shared node content fresh#1147
sid597 wants to merge 1 commit into
mainfrom
eng-1852-keep-roam-shared-node-content-fresh-in-the-sync-loop

Conversation

@sid597

@sid597 sid597 commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Extends the existing Roam Supabase sync loop to refresh already-shared source nodes.
  • Detects shared source pages whose Roam page content changed via :page/edit-time or title-level :edit/time.
  • Uploads refreshed full markdown content without running embeddings, while keeping direct/direct_and_description embedding updates on the existing changed-node path.
  • Carries the matched node type through the shared freshness query so required schema metadata stays current.
  • Adds the compact full-markdown validation artifact as a typed example.

Base / dependencies

ENG-1848 and ENG-1849 have landed on main, so this PR has been rebased onto current main and now contains only the ENG-1852 freshness-layer commit.

Validation

  • pnpm install --frozen-lockfile after rebasing onto current main
  • pnpm --filter roam check-types
  • pnpm --filter @repo/database check-types
  • pnpm --filter roam lint (0 errors, existing warnings remain)
  • git diff --check origin/main...HEAD

Note: local shell is still on Node 20.20.1, while current main asks for Node >=22, so pnpm prints an engine warning locally.

@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
discourse-graph Skipped Skipped Jun 28, 2026 4:50pm

Request Review

@supabase

supabase Bot commented Jun 22, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@linear-code

linear-code Bot commented Jun 22, 2026

Copy link
Copy Markdown

ENG-1852

@sid597 sid597 changed the base branch from main to eng-1848-add-roam-full-markdown-content-variant-for-shared-nodes June 22, 2026 16:13
@sid597 sid597 marked this pull request as ready for review June 28, 2026 16:35
@sid597 sid597 changed the base branch from eng-1848-add-roam-full-markdown-content-variant-for-shared-nodes to main June 28, 2026 16:36
@graphite-app

graphite-app Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 554884cf58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/roam/src/utils/syncDgNodesToSupabase.ts
Comment thread apps/roam/src/utils/syncDgNodesToSupabase.ts

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread apps/roam/src/utils/syncDgNodesToSupabase.ts
@sid597 sid597 force-pushed the eng-1852-keep-roam-shared-node-content-fresh-in-the-sync-loop branch from 554884c to 116e32c Compare June 28, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant