fix(ssl): honor updated le-mail on certificate renewal#497
Open
mrrobot47 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On renewal,
getOrCreateDistinguishedName()rebuilt the CSR's distinguished name using the stored email (from first issuance) and ignored thele-mailvalue passed in. So changingle-mailnever took effect on subsequent certificates — every renewal CSR kept the original address. (The SAN list already updated correctly; only the email was sticky.)Fix
When a stored distinguished name exists, use the passed
$emailif it is non-empty, falling back to the stored email only when none is provided. The updated DN is persisted as before, so the new email sticks for future renewals. All other DN fields and the SAN list are unchanged.Testing
Manual: change
le-mail, trigger a renewal → the CSR carries the new email; with an emptyle-mail, the DN falls back to the stored address.