Backports and changes to fix CI#1161
Draft
psgreco wants to merge 13 commits into
Draft
Conversation
psgreco
force-pushed
the
elements-22-fix-ci
branch
2 times, most recently
from
September 7, 2022 00:43
1ce5299 to
c4d5a2e
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
5 times, most recently
from
October 17, 2022 15:08
d991b9f to
f1ddd5d
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
4 times, most recently
from
January 26, 2023 17:59
180e5a3 to
67df486
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
February 15, 2023 13:56
30bce12 to
b298faa
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
2 times, most recently
from
March 1, 2023 12:27
bc32ff6 to
a3dff72
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
April 17, 2023 14:53
a3dff72 to
9ef0265
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
2 times, most recently
from
July 20, 2023 00:05
d6e45b5 to
fa51e27
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
from
August 8, 2023 19:27
fa51e27 to
adbdb3d
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
3 times, most recently
from
October 2, 2023 21:16
31b5de2 to
c06a2e2
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
3 times, most recently
from
January 27, 2025 21:14
844b74e to
df4d00f
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
4 times, most recently
from
February 14, 2025 22:04
3bd4526 to
05648be
Compare
psgreco
force-pushed
the
elements-22-fix-ci
branch
12 times, most recently
from
February 22, 2025 02:40
ae4bc1c to
d2525c6
Compare
The previous logic would call it once for serializing into the filestream, and then again for serializing into the hasher. If AddrMan was changed in between these calls by another thread, the resulting peers.dat would be corrupt with non-matching checksum and data. Fix this by using HashedSourceWriter, which writes the data to the underlying stream and keeps track of the hash in one go. Github-Pull: #26909 Rebased-From: 5eabb61
This reverts commit 8cb28c2e120ad70ae14f735569c42a58f2b9f274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an always draft test PR