Skip to content

Healthchecks for sidekiq + misc fixes#1330

Merged
fbacall merged 20 commits into
masterfrom
redis-test
Jun 30, 2026
Merged

Healthchecks for sidekiq + misc fixes#1330
fbacall merged 20 commits into
masterfrom
redis-test

Conversation

@fbacall

@fbacall fbacall commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary of changes

  • Add healthcheck to sidekiq docker container
  • Ensure db healthcheck uses correct database user
  • Ensure dev containers are restarted
  • Bump vulnerable gem versions
  • Move gem auditing after tests (so they run regardless)

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree to license it to the TeSS codebase under the BSD license.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves container/runtime robustness by adding healthchecks and restart policies to the Docker Compose setup, while also updating dependencies and adjusting CI ordering to ensure tests aren’t blocked by gem auditing.

Changes:

  • Add/revise Docker Compose healthchecks (DB user fix; Sidekiq healthcheck added) and add restart: unless-stopped to dev services.
  • Bump vulnerable gem versions in Gemfile.lock.
  • Move bundle-audit step to the end of the GitHub Actions test workflow so tests run even if auditing fails.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
Gemfile.lock Bumps gem versions (e.g., concurrent-ruby, faraday) to address vulnerability/patch updates.
docker-compose.yml Adds dev container restart policies; updates Postgres healthcheck user; adds Sidekiq healthcheck.
docker-compose-prod.yml Updates Postgres healthcheck user; adds Sidekiq healthcheck in prod compose.
.github/workflows/test.yml Moves gem audit step after unit/system tests so auditing doesn’t prevent tests from running.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose.yml
Comment on lines +69 to +70
healthcheck:
test: bundle exec sidekiqmon | grep $(hostname)
Comment thread docker-compose-prod.yml
Comment on lines +74 to +75
healthcheck:
test: bundle exec sidekiqmon | grep $(hostname)
@fbacall fbacall merged commit 6e0a5be into master Jun 30, 2026
12 checks passed
@fbacall fbacall deleted the redis-test branch June 30, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants