Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions api/projects/code_references/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ class FeatureFlagCodeReferencesScanSerializer(
default=VCSProvider.GITHUB,
)
revision = serializers.CharField(max_length=100)
code_references = _CodeReferenceSubmitSerializer(
many=True, required=True, allow_empty=False
)
code_references = _CodeReferenceSubmitSerializer(many=True, required=True)


class FeatureFlagCodeReferencesRepositorySummarySerializer(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,60 @@ def test_create_code_reference__valid_payload__returns_201_with_accepted_referen
]


def test_create_code_reference__empty_references__returns_201_and_clears_previous_references(
admin_client_new: APIClient,
feature: Feature,
project: Project,
log: StructuredLogCapture,
) -> None:
# Given
with freezegun.freeze_time("2099-06-01T12:00:00+00:00"):
admin_client_new.post(
f"/api/v1/projects/{project.pk}/code-references/",
data={
"repository_url": "https://github.flagsmith.com/",
"revision": "rev-1",
"code_references": [
{
"feature_name": feature.name,
"file_path": "path/to/file.py",
"line_number": 1,
},
],
},
format="json",
)
assert ScannedCodeReferences.objects.filter(feature=feature).exists()

# When
with freezegun.freeze_time("2099-06-02T12:00:00+00:00"):
response = admin_client_new.post(
f"/api/v1/projects/{project.pk}/code-references/",
data={
"repository_url": "https://github.flagsmith.com/",
"revision": "rev-2",
"code_references": [],
},
format="json",
)

# Then
assert response.status_code == 201
assert response.data["code_references"] == []
references_response = admin_client_new.get(
f"/api/v1/projects/{project.pk}/features/{feature.pk}/code-references/",
)
assert references_response.status_code == 200
assert references_response.json() == []
assert log.events[-1] == {
"event": "scan.created",
"level": "info",
"organisation__id": project.organisation_id,
"code_references__count": 0,
"feature__count": 0,
}


def test_create_code_reference__not_authenticated__returns_401(
client: APIClient,
project: Project,
Expand Down
Loading