feat(php-upgrade): Return empty string instead of null for STRING columns in cast()#3
Open
pankajrwr wants to merge 6 commits into
Open
feat(php-upgrade): Return empty string instead of null for STRING columns in cast()#3pankajrwr wants to merge 6 commits into
pankajrwr wants to merge 6 commits into
Conversation
pankajrwr
requested review from
adamjudd,
brettflorio,
filipcujanovic and
stremglav
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is made to make the localdev submodules compatible with new php version 8.2.
Without this change we have to fall to
?? ''everywhere in foxycart and hApi repos. But with this change we would return empty string instead of null for the columns which are set to be of string type.Note: Our local and production environments use
upgradebranch to pull active-record. Instead of making changes directly toupgradebranch I created a new branch and once we are done with php upgrade, means the php version upgrade changes have been merged to master branch for foxycart and hApi repos, we will merge thephp-upgradebranch here toupgradebranch and will point the composer-lock.json back toupgradebranch in hApi repo.