Skip to content

fix: better init of spergel HLR and tabulate xValue#258

Draft
beckermr wants to merge 17 commits into
mainfrom
test-spergel
Draft

fix: better init of spergel HLR and tabulate xValue#258
beckermr wants to merge 17 commits into
mainfrom
test-spergel

Conversation

@beckermr

Copy link
Copy Markdown
Collaborator

This PR has a new way to initialize the spergel HLR and a better way to compute autodiff using implicit differentiation.

@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by ×3

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 30 untouched benchmarks
🆕 2 new benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_benchmark_spergel_init[run] 6.7 µs 41.7 µs -84.02%
Simulation test_benchmark_spergel_init[run] 103.7 µs 267 µs -61.16%
Simulation test_benchmark_spergel_xvalue[run] 34,863.3 ms 309.7 ms ×110
WallTime test_benchmark_spergel_xvalue[run] 1,510.6 ms 39.1 ms ×39
Simulation test_benchmark_spergel_calcfluxrad[run] 1,091.3 µs 625 µs +74.6%
WallTime test_benchmark_spergel_calcfluxrad[run] 181.7 µs 118.5 µs +53.36%
🆕 Simulation test_benchmark_spergel_init_float[run] N/A 105.1 µs N/A
🆕 WallTime test_benchmark_spergel_init_float[run] N/A 6.9 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing test-spergel (340a5cf) with main (040d8b2)

Open in CodSpeed

Comment thread jax_galsim/spergel.py Outdated
@beckermr beckermr changed the title fix: better init of spergel HLR fix: better init of spergel HLR and tabulate xValue Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant