Skip to content

[Fixes #14367] Error in src mount point#14368

Merged
etj merged 1 commit into
masterfrom
14367_mount_src
Jun 22, 2026
Merged

[Fixes #14367] Error in src mount point#14368
etj merged 1 commit into
masterfrom
14367_mount_src

Conversation

@etj

@etj etj commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #14367

Reinstate path before
729ce51#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L14

No backport needed since the issue is on master only.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@etj etj requested a review from mattiagiupponi June 22, 2026 10:42
@etj etj self-assigned this Jun 22, 2026
Copilot AI review requested due to automatic review settings June 22, 2026 10:42
@etj etj added the master label Jun 22, 2026
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jun 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docker-compose.yml file to mount the host directory directly to /usr/src/geonode by default. Feedback indicates that this change can overwrite the container's internal directory in environments where only configuration files are present, causing container startup failures. It is recommended to keep this volume mount commented out by default or move it to a local development override file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker-compose.yml
- .env${ENVIRONMENT:+_${ENVIRONMENT}}
volumes:
# - './src:/usr/src/geonode' # Uncomment for local development
- '.:/usr/src/geonode'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Mounting the host directory . directly to /usr/src/geonode by default (uncommented) will overwrite the container's internal /usr/src/geonode directory. When running the stack in environments where only the docker-compose.yml and .env files are present (e.g., production deployments using pre-built images), this mount will replace the application code and entrypoint script with just those configuration files, causing the container to fail to start with a "file not found" error for /usr/src/geonode/entrypoint.sh.

To prevent this, the volume mount for local development should either be commented out by default (as it was previously) or moved to a docker-compose.override.yml file specifically meant for local development.

    # - '.:/usr/src/geonode'  # Uncomment for local development

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the root docker-compose.yml to address the /usr/src/geonode source mount mismatch that causes entrypoint.sh to be missing when a local bind mount is used.

Changes:

  • Replaces the prior (commented) ./src:/usr/src/geonode development volume with a bind mount of the repository root to /usr/src/geonode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker-compose.yml
Comment on lines 10 to 12
volumes:
# - './src:/usr/src/geonode' # Uncomment for local development
- '.:/usr/src/geonode'
- statics:/mnt/volumes/statics
@etj etj merged commit a1f0c2d into master Jun 22, 2026
17 checks passed
@etj etj deleted the 14367_mount_src branch June 22, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in src mount point

3 participants