Skip to content

Implement lazy loading for combobox technology icons using IntersectionObserver #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-ostapenko merged 2 commits into from
Jun 8, 2026
Merged

Implement lazy loading for combobox technology icons using IntersectionObserver #1264

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e35f0
feat: implement lazy loading for combobox technology icons using Inte…
max-ostapenko Jun 5, 2026
cf5e356
Update src/js/techreport/combobox.js
tunetheweb Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 39 additions & 5 deletions src/js/techreport/combobox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,35 @@ class ComboBox {
const rows = data || this.data;
// Add options in the dropdown list
const listbox = this.element.querySelector('[role="listbox"]');

// Typing in the filter box does work for loading=lazy
// so use a manual IntersectionObserver for now.
const hasObserver = typeof IntersectionObserver !== 'undefined';
Comment thread
tunetheweb marked this conversation as resolved.
if (hasObserver) {
if (!this.observer) {
this.observer = new IntersectionObserver((entries) => {
entries.forEach(entry => {
if (entry.isIntersecting) {
const option = entry.target;
const icon = option.dataset.icon;
if (icon && !option.querySelector('img')) {
const logo = document.createElement('img');
logo.setAttribute('alt', '');
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${encodeURI(icon)}`);
option.append(logo);
}
this.observer.unobserve(option);
}
});
}, {
root: listbox,
rootMargin: '100px',
});
} else {
this.observer.disconnect();
}
}

rows.forEach((row, index) => {
const icon = row.icon;
const option = document.createElement('div');
Expand All @@ -30,11 +59,16 @@ class ComboBox {
option.textContent = row.technology;
option.id = `${this.element.dataset.id}-${row.technology.replaceAll(' ','-')}`;
if(icon) {
const logo = document.createElement('img');
logo.setAttribute('alt', '');
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${icon}`);
logo.setAttribute('loading', 'lazy');
option.append(logo);
if (hasObserver) {
option.dataset.icon = icon;
this.observer.observe(option);
} else {
const logo = document.createElement('img');
logo.setAttribute('alt', '');
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${encodeURI(icon)}`);
logo.setAttribute('loading', 'lazy');
option.append(logo);
}
}
if(this.selected.includes(row.technology)) {
option.setAttribute('aria-selected', true);
Expand Down
Loading