Show collection descriptions in the /collections dropdown#93
Merged
Conversation
Render each option in the collection picker with the collection name in bold above its description, so users can tell what a collection contains without having to parse the name first. The closed selector still shows just the name (optionLabelProp), and virtualization is disabled so the multi-line options are not clipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the
/collectionspage, the collection picker previously listed only the collection names, asking users to parse the jargon before knowing what each collection contains. This shows the description inside each dropdown option, with the collection name in bold above its description.Changes
Selectnow renders the collection name (bold) above its description.optionLabelProp="label"), and search still filters by name (optionFilterProp="label").virtual={false}) so the multi-line options aren't clipped to a single row, and apopupClassNamelets the option content wrap.Descriptions come from
collections.json(added in the collections redesign), so no new content is hardcoded.Test plan
npm start, log in, open/collections.