reject metal surface creation when extension not enabled#1962
Merged
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 29796. |
charles-lunarg
approved these changes
Jul 7, 2026
|
CI Vulkan-Loader build # 3618 running. |
|
CI Vulkan-Loader build # 3618 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through each surface terminator's disabled-extension branch. terminator_CreateMetalSurfaceEXT logs the "extension not enabled" warning and then keeps going: it allocates the VkIcdSurface, copies the create_info and returns the handle with VK_SUCCESS. The other Create*Surface terminators refuse that branch, most returning VK_ERROR_EXTENSION_NOT_PRESENT. Metal is the only one that hands back a live surface for an extension the caller never enabled.
The vkGetInstanceProcAddr gate hides this on the usual resolution path, but the exported vkCreateMetalSurfaceEXT trampoline reaches the terminator directly, as does a layer calling down the chain. Fix sets the error and jumps to the shared cleanup so the behaviour matches the siblings. Added a regression test that drives the exported entrypoint on an instance that only enabled VK_KHR_surface.