feat(coding-plans): add MiniMax token tiers#4269
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe only change since the last review is a test-only fixture fix that correctly mocks Files Reviewed (1 file)
Previous Review Summaries (2 snapshots, latest commit 53a8900)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 53a8900)Status: No Issues Found | Recommendation: Merge Executive SummaryBoth previously flagged WARNINGs are fixed at HEAD (53a8900): the unique index migration now uses Files Reviewed (23 files)
Previous review (commit a2fbcb2)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (23 files)
Reviewed by claude-sonnet-5-20260630 · Input: 32 · Output: 9.5K · Cached: 864.1K Review guidance: REVIEW.md from base branch |
a2fbcb2 to
53a8900
Compare
Summary
minimaxand catalog feature metadata.(user_id, provider_id)foractiveorpast_duerows.Verification
Visual Changes
No screenshots captured. UI changes are limited to existing Subscription Center and admin Coding Plans surfaces:
Reviewer Notes
Local validation guide
Start local dependencies and apply migrations:
docker compose -f dev/docker-compose.yml ps postgrespnpm test:db.UQ_coding_plan_sub_live_user_provideron(user_id, provider_id)foractiveandpast_due.Run the targeted automated checks:
pnpm --filter web test -- apps/web/src/lib/coding-plans/index.test.ts apps/web/src/routers/coding-plans-router.test.ts apps/web/src/lib/coding-plans/billing-lifecycle-cron.test.ts apps/web/src/components/subscriptions/helpers.test.ts apps/web/src/routers/byok-router.test.ts packages/db/src/schema.test.tspnpm --filter @kilocode/db typecheckpnpm --filter web typecheckscripts/typecheck-all.sh --changes-onlypnpm formatValidate catalog and pricing behavior:
minimax-token-plan-plus,minimax-token-plan-max, andminimax-token-plan-ultra.providerId: "minimax".$20 /month,$50 /month, and$120 /month.~1.7Band3-4,~5.1Band4-5,~12.5Band6-7.Validate purchase and exclusivity behavior:
Validate BYOK blocking behavior:
Validate Admin UI upload behavior:
pnpm dev:start./admin/coding-plansas an admin.minimaxand Plan offers Plus, Max, and Ultra filtered by provider.<api key>::<upstream plan id>.Validate user UI behavior:
/subscriptions#coding-plans.Validate renewal billing:
50_000_000microdollars and descriptionCoding plan renewal: MiniMax Token Plan Max.120_000_000microdollars.Checks run in this session
pnpm formatpnpm --filter web test -- apps/web/src/components/subscriptions/helpers.test.ts apps/web/src/lib/coding-plans/inventory-validation.test.ts --runInBandpnpm --filter @kilocode/db typecheckpnpm --filter web typecheckscripts/typecheck-all.sh --changes-onlygit diff --checkNot run here
docker compose -f dev/docker-compose.yml ps postgresandpnpm test:dbfailed to connect to the Docker socket.Implementation notes
provider_idis the exclusivity key; this branch does not addexclusive_group_id.(user_id, plan_id)partial unique index remains because Drizzle generated only the new provider-level index..plans/minimax-token-plan-tiers.mdis saved locally as requested, but.plans/*is ignored by the repo and was not force-added.