-
Notifications
You must be signed in to change notification settings - Fork 48
fix(kiloclaw): resolve kilo-chat attachments against the agent working dir #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
78d4fc8
fix(mobile): make agent approval cards scroll instead of overflowing …
iscekic f763bdd
fix(mobile): render markdown tables as a chip that opens a full-scree…
iscekic 617483a
fix(kiloclaw): resolve kilo-chat attachments against the agent workin…
iscekic 53128a7
Merge branch 'main' into fix/kilo-chat-attach-agent-workdir
iscekic 2375253
fix(kiloclaw): tighten hasUriScheme to avoid misclassifying colon fil…
iscekic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low, Functional:
hasUriSchemerequiring://treats scheme-only URIs likedata:as relative filesystem paths.Nice tightening here. Requiring
://cleanly fixes the earlier problem where a filename such asreport:2026-07-03.mdwas misread as a URI, and the regression test locks that in.One edge worth a thought: some legitimate URIs are schemed but have no authority component, so no
//. The clearest example is adata:URI (data:text/plain;base64,...), andmailto:/blob:are similar. With this regex those no longer short-circuit inresolveLocalMediaPath, so they fall through toresolve(agentWorkingDir(), mediaUrl)and then theworkspaceDirfallback, which turns the value into a bogus path. Because non-http values skip theisHttpUrlearly return insendKiloChatMediaMessageand reach this loader, adata:URL passed asfilePath/mediawould fail the lookup with a confusing "not found under workspace" style error rather than being handled as inline data.In practice this is low risk: the outbound flow uses base64
bufferfor direct uploads and local paths forsend, so a baredata:URL is an unlikely input, which is why this is not blocking.Suggestion: if
data:URIs are ever a possiblemediaUrl, match against an explicit allowlist of real schemes (http:,https:,data:,file:,blob:) instead of requiring://. If they are not supported anywhere upstream, a one-line comment noting that only authority-based URLs are intentionally treated as pre-resolved would document the deliberate narrowing.