StaticFetcher() Implementation + from_pdb() refactor#5436
Conversation
|
Need a bit of polishing, but the overall logic behavior with documentation is there |
|
Per AI policy, I'm declaring that I used in AI in primary two ways: IDE autocomplete and help with reviewing the docstring used for the documentation to make it look more professional. The one notable exception is that I used AI to help me draft test_multiple_downloads_existing_database and test_existing_database in testsuite/MDAnalysisTests/fetch/test_static_fetcher.py I prompt is "Is there a unique way to determine the hash in order if two files are exactly the same including modification time in python using the standard library" It gave code that used os.stat(), so I googled it and found pathlib.Path.stat().st_mtime in the official docs which I then used manually for test_existing_database and test_multiple_downloads_existing_database with no AI. |
|
By the way, I don't know why tests are failing for this? The tests that are failing aren't from my code. It is stuff like I been running my tests (not the whole test suite) locally with |
|
The failing tests are, as far as I can tell, #5382 |
Fixes #5429 and #5431
Changes made in this Pull Request:
fetch.fetchers.StaticFetcher()fetch.pdb.from_pdb()to useStaticFetchers()LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes / no
From comment: #5436 (comment)
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.