Conversation
AstPath is only used as a TypeScript type in these files, but was imported as a runtime value. prettier's standalone.mjs build does not export AstPath at runtime, which breaks bundlers that consume this package (e.g. Bun) with "No matching export in standalone.mjs for import AstPath".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AstPathwas imported as a runtime value in 13 prettier printer files, but is only ever used as a TypeScript type (generic annotations,as AstPath<...>casts).standalone.mjsbuild does not exportAstPathat runtime, so consumers bundling this package (e.g. Bun's bundler) fail with:error: No matching export in "prettier/standalone.mjs" for import "AstPath"type AstPath(or addedtypeinline in mixed imports) so no runtime import is emitted.Test plan
tsc -p tsconfig.build.jsonpasses with no errorsmpeg-sdl-editor)bun run buildsucceeds against this branch