Conversation
Updated package ecosystem to 'nuget' and set target branch to 'dev'.
* chore: Tighten static asset access, update icons and manifest Removed anonymous routes for static assets in config, updated icon files, simplified Blazor script reference in index.html, and revised app name in manifest.webmanifest. * deps: update fluent packages and remove dangling system.json * chore: update gitattributes to treat razor as csharp instead of html * fix: setting AreaRestricted="false" on all page cards fixes: #5 * fix: Refactor game name resolution and grid sorting Replaced inline game name lookups with a GameName method for consistency and reuse. Updated the Game column to use this method and enabled multi-level sorting by game name and activity name. Also applied the method to the detail view label. fixes: #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request represents the initial release and introduces several improvements across the codebase, focusing on accessibility, maintainability, and dependency management. The most significant changes include adding the
AreaRestricted="false"attribute to allFluentCardcomponents to ensure consistent rendering and accessibility, updating NuGet package dependencies, and improving code maintainability by extracting repeated logic. Additionally, configuration files for language detection and automated dependency updates have been introduced.UI Accessibility and Consistency:
AreaRestricted="false"to allFluentCardcomponents throughout the Blazor pages to ensure consistent styling and accessibility, preventing unexpected clipping or restricted content areas. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]Dependency Updates:
Microsoft.FluentUI.AspNetCore.ComponentsandMicrosoft.FluentUI.AspNetCore.Components.Iconspackages from version 4.14.2 to 4.14.3 inMW-GC.EventManager.Web.csproj.System.Text.Jsonpackage reference fromMW-GC.EventManager.Shared.csprojto reduce unnecessary dependencies.Code Maintainability:
GameName(Guid gameId)helper method inActivities.razor, improving code clarity and reducing duplication. [1] [2] [3]Tooling and Configuration:
.github/dependabot.ymlconfiguration to enable weekly automated NuGet package updates targeting thedevbranch, supporting better dependency management..gitattributesto specify language detection for.razorand.cshtmlfiles, ensuring correct syntax highlighting and statistics in repository analysis tools.