Pin actions#574
Conversation
Yaswant Pradhan (yaswant)
requested review from
Matthew Hambley (MatthewHambley) and
Sam Clarke-Green (t00sa)
as code owners
Yaswant Pradhan (yaswant)
added
CI
Matthew Hambley (MatthewHambley)
left a comment
Matthew Hambley (MatthewHambley)
left a comment
There was a problem hiding this comment.
This seems to make sense.
| contents: read | ||
| pull-requests: write | ||
| contents: read # Requires read access to fetch source files | ||
| pull-requests: write # Required to post coverage metrics, test results, or status logs back into PR comments |
There was a problem hiding this comment.
I don't think we do any of these things in this repository. In which case, is it a good idea to provide the permission?
There was a problem hiding this comment.
Well spotted Matthew Hambley (@MatthewHambley)
In its current state, this is superfluous. Do we have plan to post a comment in PR e.g., if the coverage drops below a certain threshold? If not I can remove the permission now.
There was a problem hiding this comment.
We would certainly consider it, but not immediately.
Ideally GitHub's own coverage reporting (which is on trial at the moment) would be extended to work on forked pull requests. Then we would use that.
Yaswant Pradhan (yaswant)
requested a review
from Matthew Hambley (MatthewHambley)
Matthew Hambley (MatthewHambley)
left a comment
Matthew Hambley (MatthewHambley)
left a comment
There was a problem hiding this comment.
This is a straight forward change.
2 participants
closes #573