Skip to content

[HOTE-1933] feat: acute supplier specs#58

Merged
ronanoconnor1 merged 9 commits into
mainfrom
feature/HOTE-1933/acute-supplier-specs
Jul 24, 2026
Merged

[HOTE-1933] feat: acute supplier specs#58
ronanoconnor1 merged 9 commits into
mainfrom
feature/HOTE-1933/acute-supplier-specs

Conversation

@ronanoconnor1

@ronanoconnor1 ronanoconnor1 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ronanoconnor1
ronanoconnor1 requested review from a team as code owners July 23, 2026 16:04
Comment thread docs/test-types/hiv.md Outdated
Comment thread docs/test-types/hiv.md
Comment thread docs/test-types/hiv.md
Comment thread docs/test-types/hiv.md Outdated
Comment thread docs/test-types/hiv.md Outdated
Comment thread docs/test-types/hiv.md
Comment thread docs/test-types/psa.md
Comment thread docs/test-types/psa.md
Comment thread docs/test-types/psa.md
Comment thread docs/test-types/psa.md
Comment thread schemas/supplier-api-spec-v2.yaml
Comment thread schemas/supplier-api-spec-v2.yaml
Comment thread schemas/supplier-api-spec-v2.yaml
Comment thread schemas/supplier-api-spec-v2.yaml Outdated

@trawlinson-kainos trawlinson-kainos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot to discuss - very happy to approve though if we just want to go ahead with an initial proposal. Very hard to get this right in one hit I think, so we should expect iteration and this is just a starting place.

@trawlinson-kainos

Copy link
Copy Markdown
Contributor

Following discussion we've just had, I think only the change from Observation to DiagnositicReport + Observation Bundle is left at the moment :)

@sonarqubecloud

Copy link
Copy Markdown

@trawlinson-kainos

Copy link
Copy Markdown
Contributor

Super happy, results bundle matches the existing format for HIV, exciting :)

@ronanoconnor1
ronanoconnor1 merged commit bdd6521 into main Jul 24, 2026
3 checks passed
@ronanoconnor1
ronanoconnor1 deleted the feature/HOTE-1933/acute-supplier-specs branch July 24, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants