ENG-1345 selection_tag docs#130
Open
terado wants to merge 3 commits into
Open
Conversation
Co-authored-by: hirra-farooq <85997380+hirra-farooq@users.noreply.github.com>
| For **non-production** environments, you have flexibility: | ||
|
|
||
| - Use the same tag (`NHSE-Enable-Backup` = `True`) if you are going to create a single backup plan in the account. | ||
| - Use a different tag value (e.g. `NHSE-Enable-Backup` = `dev`) or a different tag key entirely (e.g. `BackupDev` = `True`) if you need to distinguish which resources belong to which environment's backup plan. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Use a different tag value (e.g. `NHSE-Enable-Backup` = `dev`) or a different tag key entirely (e.g. `BackupDev` = `True`) if you need to distinguish which resources belong to which environment's backup plan. | |
| - Use a different tag values (e.g. `NHSE-Enable-Backup` = `dev`) or a different tag keys entirely (e.g. `BackupDev` = `True`) if you will have multiple backup plans in the account and need to distinguish which resources belong to which backup plan. |
| # Use any tag key that suits your project. For production, we recommend "NHSE-Enable-Backup". | ||
| # For multi-environment accounts, use a distinct tag per environment to avoid plan collisions. | ||
| # See the Tagging Strategy section in the root README for full guidance. | ||
| "selection_tag" : "NHSE-Enable-Backup" |
Contributor
There was a problem hiding this comment.
After speaking to Susana as well i think we should remove "selection_tags" section from the example to deter people from further using it. and potentially leave a comment saying further information and possible extensions of section_tags can be found in # See the Tagging Strategy section in the root README for full guidance.
Contributor
|
Comment from Susana - also update the readme / any where else that we users of this blueprint should not copy this blueprint into their own repos but should use as a terraform module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
selection_tag documentation changes