[18.0][FIX] web_pwa_customize: PWA manifest, browser theme-color#3603
Open
jans23 wants to merge 1 commit into
Open
[18.0][FIX] web_pwa_customize: PWA manifest, browser theme-color#3603jans23 wants to merge 1 commit into
jans23 wants to merge 1 commit into
Conversation
Contributor
|
Hi @victoralmau, |
victoralmau
suggested changes
Jul 3, 2026
victoralmau
left a comment
victoralmau
left a comment
Member
There was a problem hiding this comment.
It also removes empty lines within the _get_webmanifest() method.
The license change is because it was initially defined incorrectly; I don't think it will be a problem.
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
| { | ||
| "name": "Web Pwa Customize", | ||
| "version": "18.0.1.1.0", |
Member
There was a problem hiding this comment.
Suggested change
| "version": "18.0.1.1.0", | |
| "version": "18.0.1.0.0", |
It is not necessary to change the version.
| <template | ||
| id="webclient_bootstrap_pwa" | ||
| inherit_id="web.webclient_bootstrap" | ||
| priority="99" |
Member
There was a problem hiding this comment.
Suggested change
| priority="99" |
jans23
force-pushed
the
18.0-fix-web_pwa_customize
branch
from
a4067a7 to
a778278
Compare
Author
|
@victoralmau changed as requested. |
jans23
force-pushed
the
18.0-fix-web_pwa_customize
branch
from
a778278 to
1f4b5d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the work in #3501 and incorporates Victor's feedback as well as some minor improvements.