Enable more testsets#13
Merged
Merged
Conversation
Our oldest Ubuntu container doesn't support ping -6, yet. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Our oldest Ubuntu containers don't have the /usr merger, yet. So ip is only available at one path and that is /sbin/ip. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Notes: * Testset 22 does not actually work, yet. There is some TLS handshake error during connection * This makes the copy & paste situation even worse. We really should try to get this consolidated. But for that we need a working base. * In many cases this deletes the expected ip addresses. Since the older t_client.rc versions do not record the ip addresses this slightly reduces the test coverage. But if we address the copy & paste issues the older t_client.rc files should achieve better feature-parity. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
My version from https://gerrit.openvpn.net/c/openvpn/+/1764 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
- Use needs_openvpn where required - In some cases --setenv opt can also be used Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Since we increased the verbosity, we need a summary at the end. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
- Make sure to enable legacy crypto policy on server side - Adapt t_client.rc. In this case we do not share the config with the other testsets since it is so minimal and different (e.g. no IPv6). - Remove tls-version-min 1.1 from tun-udp-p2mp Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
- Remove a lot of useless comments from the sample config file - Remove tap-inetd-p2p/, unused Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
There was a problem hiding this comment.
Pull request overview
This PR expands the OpenVPN test matrix by enabling additional client test sets and updating the test server/client configurations to improve compatibility with older OpenVPN versions (notably 2.2/2.3).
Changes:
- Enable running multiple client test sets (22–27 + master) and add a summary output in the test runner.
- Adjust server configs to be more compatible with older clients (e.g., add BF-CBC where needed, simplify configs).
- Refactor
t_clientrunner/config selection and add version-gated test selection (needs_openvpn).
Reviewed changes
Copilot reviewed 26 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| t_server/tofu/modules/tserver_user_data/provision/28-setup-test-dependencies.sh | Provisioning tweaks for legacy client compatibility and test proxies. |
| t_server/original/t_server/tun-udp-p2p/server.conf | Simplify config; keep static-crypto compatibility behavior. |
| t_server/original/t_server/tun-udp-p2p-tls-sha256/server.conf | Simplify TLS P2P config and remove commented sample blocks. |
| t_server/original/t_server/tun-udp-p2mp/server.conf | Simplify P2MP config and reintroduce BF-CBC for older client compatibility. |
| t_server/original/t_server/tun-udp-p2mp-topology-subnet/server.conf | Simplify config; add BF-CBC and keep TLS min version compatible with old clients. |
| t_server/original/t_server/tun-udp-p2mp-hash-defscript/server.conf | Simplify config; add BF-CBC for older clients. |
| t_server/original/t_server/tun-udp-p2mp-hash-defscript/.gitignore | Ignore auth script log output file. |
| t_server/original/t_server/tun-udp-p2mp-global-authpam/server.conf | Simplify config; add BF-CBC for older clients. |
| t_server/original/t_server/tun-udp-p2mp-global-authpam/.gitignore | Ignore auth script log output file. |
| t_server/original/t_server/tun-udp-p2mp-fragment/server.conf | Simplify fragment test config; add BF-CBC for older clients. |
| t_server/original/t_server/tun-udp-p2mp-112-mask/server.conf | Simplify IPv6-only/tls-crypt test config; add BF-CBC for older clients. |
| t_server/original/t_server/tun-udp-p2mp-112-mask/.gitignore | Ignore tls-crypt-v2 verify output artifact. |
| t_server/original/t_server/tun-tcp-p2mp/server.conf | Simplify TCP P2MP config; add BF-CBC for older clients. |
| t_server/original/t_server/tap-udp-p2mp/server-mixed.conf | Simplify TAP config; add BF-CBC and keep TLS min version compatible. |
| t_server/original/t_server/tap-udp-p2mp/ccd/tserver-client-24 | Add CCD entry for a VLAN-tagged client test case. |
| t_server/original/t_server/tap-udp-p2mp/ccd/tserver-client-23 | Add CCD entry for a VLAN 200 client test case. |
| t_server/original/t_server/tap-tcp-p2p/server.conf | Simplify TCP TAP P2P TLS server config. |
| t_server/original/t_server/tap-inetd-p2p/server.conf | Remove inetd-based TAP P2P server config. |
| t_server/original/t_server/tap-inetd-p2p/do-inetd-ifconfig.sh | Remove inetd helper script. |
| t_server/original/run_t_clients.sh | Enable more test sets and write a consolidated summary. |
| t_server/original/client_vm/t_client.master/t_client.rc | Expand/adjust master test list, add version-gated feature usage, and refactor common conf fragments. |
| t_server/original/client_vm/t_client.22/t_client.rc | Rebase 2.2 client config on deployment config + cached IPs, and update key/cert paths. |
| t_server/original/client_vm/bin/t_client.sh | Refactor rc discovery, add needs_openvpn, adjust logging, and change output helpers. |
| t_server/original/client_vm/bin/ping8.sh | Switch IPv6 ping invocation used by test 8 up-script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also fix two errors in the base variables identified by Copilot review: - Fix typo in one BASE_CONF_2 reference - Remove redundant --proto from BASE_CONF_8 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.