Skip to content

chore: bump to .NET 10#3116

Open
LuLu-ling wants to merge 6 commits into
devfrom
chore/bump-to-dotnet-10
Open

chore: bump to .NET 10#3116
LuLu-ling wants to merge 6 commits into
devfrom
chore/bump-to-dotnet-10

Conversation

@LuLu-ling

@LuLu-ling LuLu-ling commented Jun 12, 2026

Copy link
Copy Markdown
Member

先放在这里😋

Summary by Sourcery

更新运行时要求和文档,使其面向 .NET 10。

增强内容:

  • 更新应用程序错误处理,将用户引导至安装 .NET 10 Desktop Runtime。
  • 统一英文版和中文版 README 中的系统要求,使其与 .NET 10 Desktop Runtime 和 SDK 保持一致。
Original summary in English

Summary by Sourcery

Update runtime requirements and documentation to target .NET 10.

Enhancements:

  • Update application error handling to direct users to install the .NET 10 Desktop Runtime.
  • Align English and Chinese README system requirements with .NET 10 Desktop Runtime and SDK.

@pcl-ce-automation pcl-ce-automation Bot added 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查 size: S PR 大小评估:小型 labels Jun 12, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
审阅者指南(在小型 PR 上折叠)

审阅者指南

.NET 运行时和文档引用已从 .NET 8 更新为 .NET 10,包括面向用户的错误消息、README 要求表,以及项目配置文件,以使整个解决方案与 .NET 10 保持一致。

.NET 10 运行时错误处理更新的时序图

sequenceDiagram
    actor User
    participant App as Application
    participant ModBase
    participant LogWrapper

    User->>App: Run application
    App->>App: Application_DispatcherUnhandledException
    App->>ModBase: OpenWebsite(https_get_dot_net_10)
    App->>LogWrapper: Error(Exception, Your_NET_Desktop_Runtime_is_outdated_or_corrupted_Please_reinstall_NET_10)
Loading

文件级更改

更改 详情 文件
在缺少或损坏必需的 Desktop Runtime 时,将运行时下载链接和错误消息从引用 .NET 8 更新为引用 .NET 10。
  • 修改 Application.xaml.cs 中未处理异常处理程序,使其打开 .NET 10 下载 URL,而不是 .NET 8 的 URL。
  • 调整日志中的错误消息文本,引导用户重新安装 .NET 10,而不是 .NET 8。
Plain Craft Launcher 2/Application.xaml.cs
使受支持的操作系统和运行时要求文档与 .NET 10 保持一致。
  • 更新 README-EN.md 中的 Windows 支持矩阵,将要求从 .NET 8 改为 .NET 10 Desktop Runtime 和 SDK。
  • 更新 README-ZH_TW.md 中的 Windows 支持矩阵,将要求从 .NET 8 改为 .NET 10 Desktop Runtime 和 SDK。
  • 更新 README.md(简体中文)中的 Windows 支持矩阵,将要求从 .NET 8 改为 .NET 10 Desktop Runtime 和 SDK。
README-EN.md
README-ZH_TW.md
README.md
更新项目配置以针对 .NET 10(具体细节未在 diff 中完全展示)。
  • 调整 PCL.Core.Test.csproj,使其以 .NET 10 工具链/运行时为目标或引用它。
  • 调整 PCL.Core.csproj,使其以 .NET 10 工具链/运行时为目标或引用它。
  • 调整 Plain Craft Launcher 2.csproj,使其以 .NET 10 工具链/运行时为目标或引用它。
PCL.Core.Test/PCL.Core.Test.csproj
PCL.Core/PCL.Core.csproj
Plain Craft Launcher 2/Plain Craft Launcher 2.csproj

技巧与命令

与 Sourcery 交互

  • 触发新的审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub issue: 通过回复审阅评论来请求 Sourcery 从该评论创建一个 issue。你也可以在审阅评论中回复 @sourcery-ai issue 来从该评论创建 issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title,随时(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文任意位置写上 @sourcery-ai summary,即可在你指定的位置随时生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary,随时(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,以解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 清除所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,以清除所有现有的 Sourcery 审阅。尤其适用于你想从头开始新的审阅时——别忘了再评论 @sourcery-ai review 来触发新的审阅!

自定义你的使用体验

访问你的 控制面板 以:

  • 启用或禁用审阅功能,例如 Sourcery 生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、移除或编辑自定义审阅指令。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

.NET runtime and documentation references have been updated from .NET 8 to .NET 10, including user-facing error messaging, README requirements tables, and project configuration files to align the solution with .NET 10.

Sequence diagram for .NET 10 runtime error handling update

sequenceDiagram
    actor User
    participant App as Application
    participant ModBase
    participant LogWrapper

    User->>App: Run application
    App->>App: Application_DispatcherUnhandledException
    App->>ModBase: OpenWebsite(https_get_dot_net_10)
    App->>LogWrapper: Error(Exception, Your_NET_Desktop_Runtime_is_outdated_or_corrupted_Please_reinstall_NET_10)
Loading

File-Level Changes

Change Details Files
Update runtime download link and error message to reference .NET 10 instead of .NET 8 when a required Desktop Runtime is missing or corrupted.
  • Change Application.xaml.cs unhandled-exception handler to open the .NET 10 download URL instead of the .NET 8 URL.
  • Adjust the logged error message text to instruct users to reinstall .NET 10 rather than .NET 8.
Plain Craft Launcher 2/Application.xaml.cs
Align documentation for supported OS and runtime requirements with .NET 10.
  • Update README-EN.md Windows support matrix to require .NET 10 Desktop Runtime and SDK instead of .NET 8.
  • Update README-ZH_TW.md Windows support matrix to require .NET 10 Desktop Runtime and SDK instead of .NET 8.
  • Update README.md (Simplified Chinese) Windows support matrix to require .NET 10 Desktop Runtime and SDK instead of .NET 8.
README-EN.md
README-ZH_TW.md
README.md
Update project configuration to target .NET 10 (details not fully shown in diff).
  • Adjust PCL.Core.Test.csproj to target or otherwise reference .NET 10 tooling/runtime.
  • Adjust PCL.Core.csproj to target or otherwise reference .NET 10 tooling/runtime.
  • Adjust Plain Craft Launcher 2.csproj to target or otherwise reference .NET 10 tooling/runtime.
PCL.Core.Test/PCL.Core.Test.csproj
PCL.Core/PCL.Core.csproj
Plain Craft Launcher 2/Plain Craft Launcher 2.csproj

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74d55f8b24

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Plain Craft Launcher 2/Plain Craft Launcher 2.csproj
sourcery-ai[bot]

This comment was marked as off-topic.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83c089150a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Plain Craft Launcher 2/Pages/PageSetup/PageSetupUpdate.xaml.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13e792f82c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Plain Craft Launcher 2/Pages/PageSetup/PageSetupUpdate.xaml.cs
@pcl-ce-automation pcl-ce-automation Bot added size: M PR 大小评估:中型 and removed size: S PR 大小评估:小型 labels Jun 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a2c1dc550

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

<PropertyGroup>
<Nullable>enable</Nullable>
<TargetFramework>net8.0-windows</TargetFramework>
<TargetFramework>net10.0-windows</TargetFramework>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Don't ship the net10 build through the old updater

Fresh evidence in this revision is that the new guard now checks for .NET 10, but that code only runs after a user has already installed a build containing it. Existing installed .NET 8 builds still execute their older BtnUpdate_Click guard, which only accepted Microsoft.WindowsDesktop.App 8.0., and UpdateRestart immediately starts the downloaded framework-dependent exe as the updater; on machines without the .NET 10 desktop runtime, an in-app update to this net10.0-windows artifact can therefore replace/start a binary that cannot launch before it can show the new prompt. Please add a transition path that old clients can enforce, such as update metadata/channel blocking, an external bootstrapper, or a self-contained transition build.

Useful? React with 👍 / 👎.

Comment thread README.md Outdated
@@ -151,14 +151,14 @@ private void BtnUpdate_Click(object sender, MouseButtonEventArgs e)
// 检查 .NET 版本
if (!updateInfo.VersionName.StartsWithF("2.13.") && !ModBase

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本号

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个等会再改,因为还没确定到底那个版本才会上 .NET10

@MoYuan-CN MoYuan-CN changed the title chore: bump to .Net 10 chore: bump to .NET 10 Jun 15, 2026
@RyogiMutsuki

Copy link
Copy Markdown
Member

我觉得可以考虑把官方支持提高到 19041 了,17763 真有人用吗

@Pigeon0v0

Copy link
Copy Markdown
Contributor

我觉得可以考虑把官方支持提高到 19041 了,17763 真有人用吗

你可别忘了 17763 很大程度上是为你留的 :/

@RyogiMutsuki

Copy link
Copy Markdown
Member

我觉得可以考虑把官方支持提高到 19041 了,17763 真有人用吗

你可别忘了 17763 很大程度上是为你留的 :/

现在没 1703 了.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M PR 大小评估:中型 🛠️ 等待审查 Pull Request 已完善,等待维护者或负责人进行代码审查

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants