Update CSP#504
Conversation
for more information, see https://pre-commit.ci
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
Thanks @awongel! Looks great. I have two suggestions / requests:
-
Could you remove the Saudia Arabia example? The example got quite long and to me it didn't add too many new insights.
-
Do you have a comparison of the
convert_csv()output before and after? That would make it easier to see whether the changes are plausible. Just a graphic + code snippet would be helpful.
| dask_gufunc_kwargs=dict( | ||
| output_sizes={"yout": dst_shape[0], "xout": dst_shape[1]} | ||
| output_sizes={"yout": dst_shape[0], "xout": dst_shape[1]}, | ||
| allow_rechunk=True, |
There was a problem hiding this comment.
Hi @fneum!
-
I had discussed with @euronion what we should add and felt that a second location would be useful to show that it works more generally than in a single location. If you think it's too much, I don't mind removing it again.
-
Since I replaced the calculation, would you suggest to keep the previous way of calculating it somewhere in the code? I wanted to avoid that. Or save the old result somewhere, but then you can't immediately see how it was calculated.
The change in the gis.py file was needed for the sarah data part of the example, which wouldn't run for me otherwise. Happy to remove if you can confirm this is not needed.
|
@awongel took the freedom to merge the latest master and remove the saudi arabia example. we should keep the allow_rechunk in as it is generally needed for sarah cutouts and regrid operations. I have the changes locally but don't want to push on your master unless you say its okay. alternatively I can raise another pr superseding this one |
|
@FabianHofmann, awesome, thanks for picking this up again! Yes, please feel free to push your changes directly to my master. |
3 participants
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
doc.environment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.